-
Notifications
You must be signed in to change notification settings - Fork 0
[PD1-668] Add ability to add agent post #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PD1-668 ATEK Ops Agent Page
The demo version exists in jetson, we need to remake one for the actual frontend |
Summary of ChangesHello @amy-nihao, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds the ability to create agent posts through the SDK. The overall implementation is good, but I've identified a critical issue that would cause an ImportError and break the package. Additionally, there are a few high and medium severity issues related to type consistency and code maintainability. I have provided specific comments and code suggestions to address these points, which should improve the robustness and clarity of the new functionality.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…y/cvec-python into amy/add-agent-post
joshuanapoli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
I tested this in the context of https://github.com/CVector-Energy/cvec-data-analysis/pull/2
Description
Add the ability to push agent posts to the frontend by going through
cvec-backendendpoint. In the future I think we should add the ability to get/update the posts, or internally allow edits in the frontend. Currently the only way to fix a mistake in a post is to edit it from supabase or delete and make a new one.Risk
We are making the process to add agent posts public by adding it here. This is not ideal and we should have a private sdk repo soon
Test
Tested with https://github.com/CVector-Energy/cvec-backend/pull/88