-
Notifications
You must be signed in to change notification settings - Fork 0
[PD1-662] Bump version number #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @joshuanapoli, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the project's version number, signifying a new release or a set of updates to the package. This change is crucial for proper package management and deployment. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request bumps the project version from 1.1.1 to 1.2.0, which, according to the description, is for a new PyPI release that replaces the requests library with urllib. While the version bump is appropriate for such a change, it has caused an inconsistency with the poetry.lock file. The lock file was not updated to reflect the new version in pyproject.toml, which will likely cause issues with dependency installation and continuous integration checks. It's crucial to keep pyproject.toml and poetry.lock synchronized.
PD1-662 Alarm on IoT devices
Initial alarm proposal drafted here: https://cvector.slite.com/app/docs/LMpkl5R2PeB4Q0 It was decided to not add a broker for now. Instead, we will fetch data directly from TimescaleDB.
CloudWatch => rule engine
|
olivierpichon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @joshuanapoli ⭐
Update on PyPI, replacing
requestswithurllib