Skip to content

Conversation

@joshuanapoli
Copy link
Member

Update on PyPI, replacing requests with urllib

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @joshuanapoli, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the project's version number, signifying a new release or a set of updates to the package. This change is crucial for proper package management and deployment.

Highlights

  • Version Bump: The project's version number has been incremented from "1.1.1" to "1.2.0" in the pyproject.toml file.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request bumps the project version from 1.1.1 to 1.2.0, which, according to the description, is for a new PyPI release that replaces the requests library with urllib. While the version bump is appropriate for such a change, it has caused an inconsistency with the poetry.lock file. The lock file was not updated to reflect the new version in pyproject.toml, which will likely cause issues with dependency installation and continuous integration checks. It's crucial to keep pyproject.toml and poetry.lock synchronized.

@joshuanapoli joshuanapoli changed the title Bump version number [PD1-662] Bump version number Nov 24, 2025
@linear
Copy link

linear bot commented Nov 24, 2025

PD1-662 Alarm on IoT devices

Initial alarm proposal drafted here: https://cvector.slite.com/app/docs/LMpkl5R2PeB4Q0

It was decided to not add a broker for now. Instead, we will fetch data directly from TimescaleDB.
Suggested architecture:
A Lambda function => metric aggregator

  • Runs every minute
  • Reads from TigerData
  • Emits a small set of numeric metrics to CloudWatch

CloudWatch => rule engine

  • Stores alarm definitions (thresholds, periods, etc.)
  • Evaluates conditions
  • Sends notifications (Slack via SNS/Lambda)

Copy link

@olivierpichon olivierpichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @joshuanapoli

@joshuanapoli joshuanapoli merged commit 47bca19 into main Nov 24, 2025
4 checks passed
@joshuanapoli joshuanapoli deleted the v1.2.0 branch November 24, 2025 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants