-
Notifications
You must be signed in to change notification settings - Fork 0
[PD1-242] Replace requests dependency with urllib #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Update GitHub Actions to use ubuntu-24.04 runner. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
PD1-242 Upgrade GitHub Actions to Report Licenses and use Ubuntu 24.04
License CheckerWe need an Open Source license report for our new investor. Each repo can write to one or more CSV license report file in a bucket owned by the audit account, cvecaudit-licenses. So s3://cvecaudit-licenses/cvec-backend.python.csv would have the license report for the Python dependencies of the cvec-backend repo. Some project, like I will need the CSV files to have a standard column structure. I will add a tool to cvec-management-account to accumulate all of the reports. The tool will iterate the list of unarchived repos, and load the CSV license report for each. This way, when we retire a repo, it is removed from the license report. It looks like there is no way to report on Docker images. We can, however, scrape licenses from our Ubuntu systems from Ubuntu UpgradeStandard support for Ubuntu 22.04 ends April 2027. Standard support for Ubuntu 24.04 ends April 2029. |
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
5c19cf7 to
3a37e20
Compare
Replace the requests library with Python's built-in urllib to eliminate external HTTP dependency. This change uses urllib.request, urllib.error, and urllib.parse for all HTTP operations while maintaining the same functionality. Changes: - Updated CVec class to use urllib instead of requests - Modified test mocks to work with urllib - Updated error handling in csv_import script - Removed requests and types-requests from dependencies All tests pass successfully. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Add checks to ensure _publishable_key is not None before using it in headers dictionaries. This fixes mypy strict mode type errors while also improving runtime safety. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
a3eca6f to
93d14f4
Compare
CharlesKleeven
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Add the missing import for HTTPError from urllib.error that was referenced but not imported after removing the requests dependency. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Summary
Test plan