test: add comprehensive unit tests for rate-limiter and url-shortener#14
Merged
CSenshi merged 13 commits intoCSenshi:mainfrom Mar 27, 2026
Merged
test: add comprehensive unit tests for rate-limiter and url-shortener#14CSenshi merged 13 commits intoCSenshi:mainfrom
CSenshi merged 13 commits intoCSenshi:mainfrom
Conversation
5 tasks
Owner
|
…gation test The guard itself throws RateLimitExceededException based on result.allowed; rateLimiterService.check never throws it. Error propagation is already covered by the ECONNREFUSED test. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Removed the redundant guard test -- On the jest configs though -- reverting them back to |
Owner
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.tsto.cts(ESM__dirnameissue)135 total tests passing (44 rate-limiter + 91 url-shortener), 0 failures.
Linked Issues
N/A
Checklist
Additional Context
*.spec.tsconvention and sit alongside their source files.ts→.ctsconversion matches the pattern already used by rate-limiter'sjest.config.ctsand aligns with NX's officialconvert-jest-config-to-cjsmigration