Test: Nominee endpoint #127
Conversation
* refactored how the election officers are looked up * changed the Nominee put back to a patch * made election tests work with the new testing setup
| query = query.where(BlogPosts.title == title) | ||
|
|
||
| # should return the one entry with an unique title | ||
| post = await db_session.scalar(query) |
There was a problem hiding this comment.
nit pick: might wanna check if post is none
There was a problem hiding this comment.
It looks like the whole Blog module is a mess. It showed up here since I ran a formatter over everything. Blogs will be addressed in a future update.
| query = query.where(BlogPosts.post_tags in tags).where(BlogPosts.last_edited).order_by(BlogPosts.last_edited.desc()) | ||
| # .all() should return a list of all the posts |
There was a problem hiding this comment.
slight syntax issue for sqlalchemy. BlogPosts.post_tags in tags is invalid syntax
Correction: query = query.where(BlogPosts.post_tags.contains(tags)).order_by(BlogPosts.last_edited.desc())
There was a problem hiding this comment.
It looks like the whole Blog module is a mess. It showed up here since I ran a formatter over everything. Blogs will be addressed in a future update.
| detail="candidate is already registered for that position", | ||
| ) | ||
|
|
||
| registration.update_from_params(body) |
There was a problem hiding this comment.
Nothing asynchronous about this function.
def update_from_params(self, params: CandidateUpdate):
update_data = params.model_dump(exclude_unset=True)
for k, v in update_data.items():
setattr(self, k, v)
The commit on line 176 should update the candidate at this point.
Based off this: https://docs.sqlalchemy.org/en/21/tutorial/orm_data_manipulation.html#updating-orm-objects-using-the-unit-of-work-pattern
depends on #126