Skip to content

Comments

Handle ghost Aquatroll tables at OWC; add OWC to testing data#23

Merged
wilsonsj100 merged 5 commits intomainfrom
owc
Oct 15, 2025
Merged

Handle ghost Aquatroll tables at OWC; add OWC to testing data#23
wilsonsj100 merged 5 commits intomainfrom
owc

Conversation

@bpbond
Copy link
Member

@bpbond bpbond commented Oct 15, 2025

I experimented with changing the default column type to character, but that caused problems elsewhere. So instead in read_datalogger_file() we now ensure that any column named "Aquatroll_ID..." has been read as character:

    # Some Aquatroll tables (specifically at OWC; see e.g. #21) have blank
    # tables, and their "Aquatroll_IDx" columns get parsed as numeric, which
    # causes errors at the bind_rows() step below. Pre-emptively fix this
    fixcol <- grep("^Aquatroll_ID", colnames(x))
    if(length(fixcol) > 0) x[fixcol] <- as.character(x[fixcol])

A little hacky ☹️ but it works.

Closes #21

@bpbond bpbond requested a review from wilsonsj100 October 15, 2025 10:20
@bpbond
Copy link
Member Author

bpbond commented Oct 15, 2025

See https://rpubs.com/bpbond/1330934 for an example of plotting OWC 🎉

@bpbond bpbond mentioned this pull request Oct 15, 2025
Copy link
Contributor

@wilsonsj100 wilsonsj100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YAY! Thank you @bpbond I appreciate you decoding all these issues :) I am going to merge then try it on my own computer

@wilsonsj100 wilsonsj100 merged commit ab141a2 into main Oct 15, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Lake Erie Checks not running

2 participants