Skip to content

Add comprehensive unit tests for >80% code coverage #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devin-ai-integration wants to merge 1 commit into
base: DevOps
Choose a base branch
from
Open

Add comprehensive unit tests for >80% code coverage #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,11 @@
<artifactId>spring-security-test</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>com.h2database</groupId>
<artifactId>h2</artifactId>
<scope>test</scope>
</dependency>
</dependencies>

<build>
Expand Down
175 changes: 175 additions & 0 deletions src/test/java/com/example/bankapp/config/SecurityConfigTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,175 @@
package com.example.bankapp.config;

import com.example.bankapp.model.Account;
import com.example.bankapp.service.AccountService;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.boot.test.autoconfigure.web.servlet.AutoConfigureMockMvc;
import org.springframework.boot.test.context.SpringBootTest;
import org.springframework.boot.test.mock.mockito.MockBean;
import org.springframework.security.crypto.bcrypt.BCryptPasswordEncoder;
import org.springframework.security.crypto.password.PasswordEncoder;
import org.springframework.security.test.context.support.WithMockUser;
import org.springframework.test.web.servlet.MockMvc;

import java.math.BigDecimal;
import java.util.ArrayList;

import static org.junit.jupiter.api.Assertions.*;
import static org.mockito.Mockito.when;
import static org.springframework.security.test.web.servlet.request.SecurityMockMvcRequestPostProcessors.csrf;
import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.get;
import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.post;
import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.*;

@SpringBootTest
@AutoConfigureMockMvc
class SecurityConfigTest {

@Autowired
private MockMvc mockMvc;

@Autowired
private PasswordEncoder passwordEncoder;

@MockBean
private AccountService accountService;

private Account testAccount;

@BeforeEach
void setUp() {
testAccount = new Account();
testAccount.setId(1L);
testAccount.setUsername("testuser");
testAccount.setPassword("encodedPassword");
testAccount.setBalance(new BigDecimal("1000.00"));
testAccount.setTransactions(new ArrayList<>());
}

@Test
void passwordEncoder_ReturnsBCryptPasswordEncoder() {
assertNotNull(passwordEncoder);
assertTrue(passwordEncoder instanceof BCryptPasswordEncoder);
}

@Test
void passwordEncoder_EncodesPassword() {
String rawPassword = "testPassword123";
String encodedPassword = passwordEncoder.encode(rawPassword);

assertNotNull(encodedPassword);
assertNotEquals(rawPassword, encodedPassword);
assertTrue(passwordEncoder.matches(rawPassword, encodedPassword));
}

@Test
void passwordEncoder_DifferentEncodingsForSamePassword() {
String rawPassword = "testPassword123";
String encodedPassword1 = passwordEncoder.encode(rawPassword);
String encodedPassword2 = passwordEncoder.encode(rawPassword);

assertNotEquals(encodedPassword1, encodedPassword2);
assertTrue(passwordEncoder.matches(rawPassword, encodedPassword1));
assertTrue(passwordEncoder.matches(rawPassword, encodedPassword2));
}

@Test
void registerEndpoint_IsPublic() throws Exception {
mockMvc.perform(get("/register"))
.andExpect(status().isOk());
}

@Test
void loginEndpoint_IsPublic() throws Exception {
mockMvc.perform(get("/login"))
.andExpect(status().isOk());
}

@Test
void dashboardEndpoint_RequiresAuthentication() throws Exception {
mockMvc.perform(get("/dashboard"))
.andExpect(status().is3xxRedirection())
.andExpect(redirectedUrlPattern("**/login"));
}

@Test
void transactionsEndpoint_RequiresAuthentication() throws Exception {
mockMvc.perform(get("/transactions"))
.andExpect(status().is3xxRedirection())
.andExpect(redirectedUrlPattern("**/login"));
}

@Test
void depositEndpoint_RequiresAuthentication() throws Exception {
mockMvc.perform(post("/deposit")
.with(csrf())
.param("amount", "100.00"))
.andExpect(status().is3xxRedirection())
.andExpect(redirectedUrlPattern("**/login"));
}

@Test
void withdrawEndpoint_RequiresAuthentication() throws Exception {
mockMvc.perform(post("/withdraw")
.with(csrf())
.param("amount", "100.00"))
.andExpect(status().is3xxRedirection())
.andExpect(redirectedUrlPattern("**/login"));
}

@Test
void transferEndpoint_RequiresAuthentication() throws Exception {
mockMvc.perform(post("/transfer")
.with(csrf())
.param("toUsername", "recipient")
.param("amount", "100.00"))
.andExpect(status().is3xxRedirection())
.andExpect(redirectedUrlPattern("**/login"));
}

@Test
@WithMockUser(username = "testuser")
void authenticatedUser_CanAccessDashboard() throws Exception {
when(accountService.findAccountByUsername("testuser")).thenReturn(testAccount);

mockMvc.perform(get("/dashboard"))
.andExpect(status().isOk());
}

@Test
@WithMockUser(username = "testuser")
void authenticatedUser_CanAccessTransactions() throws Exception {
when(accountService.findAccountByUsername("testuser")).thenReturn(testAccount);
when(accountService.getTransactionHistory(testAccount)).thenReturn(new ArrayList<>());

mockMvc.perform(get("/transactions"))
.andExpect(status().isOk());
}

@Test
void logout_RedirectsToLoginWithLogoutParam() throws Exception {
mockMvc.perform(post("/logout")
.with(csrf()))
.andExpect(status().is3xxRedirection())
.andExpect(redirectedUrl("/login?logout"));
}

@Test
void loginPage_HasCorrectUrl() throws Exception {
mockMvc.perform(get("/login"))
.andExpect(status().isOk())
.andExpect(view().name("login"));
}

@Test
void registerPost_WithValidData_RedirectsToLogin() throws Exception {
mockMvc.perform(post("/register")
.with(csrf())
.param("username", "newuser")
.param("password", "password123"))
.andExpect(status().is3xxRedirection())
.andExpect(redirectedUrl("/login"));
}
}
Loading