Migrate from Java 17 to Java 21 #76
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update java.version property from 17 to 21 in pom.xml - Update maven-compiler-plugin source/target from 1.8 to 21 - Update Dockerfile builder stage from openjdk-17 to openjdk-21 - Update Dockerfile runtime stage from openjdk:17-alpine to openjdk:21-alpine - Update README.md Jenkins installation from openjdk-17-jre to openjdk-21-jre Co-Authored-By: Joao Esteves <joao.esteves@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR migrates the Springboot-BankApp from Java 17 to Java 21. The current Spring Boot version (3.3.3) already supports Java 21, so no Spring Boot upgrade was required.
Changes made:
java.versionproperty from 17 to 21 in pom.xmlmaven:3.8.3-openjdk-17tomaven:3.8.3-openjdk-21openjdk:17-alpinetoopenjdk:21-alpineopenjdk-17-jretoopenjdk-21-jreReview & Testing Checklist for Human
maven:3.8.3-openjdk-21andopenjdk:21-alpineexist and are available on Docker HubRecommended test plan: Run
docker build -t bankapp .and thendocker run -p 8080:8080 bankappto verify the application starts correctly with the new Java 21 base images.Notes
Note: The maven-compiler-plugin was previously configured for Java 1.8 (source/target), which was inconsistent with the java.version property of 17. This has been updated to 21 for consistency.
Link to Devin run: https://app.devin.ai/sessions/c4d16cf3d73a4a3b87d8f7e120736101
Requested by: Joao Esteves (@joao-cognition)