Java 8 to Java 11 Migration #71
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lugins - Downgrade Spring Boot from 3.3.3 to 2.7.18 (LTS) for Java 11 compatibility - Update maven-compiler-plugin to 3.11.0 with <release>11</release> - Upgrade maven-surefire-plugin to 3.2.5 - Upgrade maven-failsafe-plugin to 3.2.5 - Add maven-enforcer-plugin 3.5.0 to require Java 11+ - Change thymeleaf-extras-springsecurity6 to springsecurity5 - Add H2 database dependency for testing Co-Authored-By: Cindy Huang <cindy.huang@cognition.ai>
- Change jakarta.persistence imports to javax.persistence in Account.java - Change jakarta.persistence imports to javax.persistence in Transaction.java - Add UserDetails interface methods to Account.java for Spring Security 5 Co-Authored-By: Cindy Huang <cindy.huang@cognition.ai>
- Change from Spring Security 6 lambda DSL to Spring Security 5 method chaining - Replace requestMatchers() with antMatchers() - Replace authorizeHttpRequests() with authorizeRequests() - Update logout, formLogin, and headers configuration Co-Authored-By: Cindy Huang <cindy.huang@cognition.ai>
- Change MySQL8Dialect to MySQL57Dialect for Hibernate 5 compatibility Co-Authored-By: Cindy Huang <cindy.huang@cognition.ai>
- Add test-specific application.properties with H2 in-memory database - Configure H2 dialect and create-drop DDL for test isolation Co-Authored-By: Cindy Huang <cindy.huang@cognition.ai>
- Add GitHub Actions workflow for Java 11 builds - Use Temurin JDK 11 distribution - Include Maven caching for faster builds Co-Authored-By: Cindy Huang <cindy.huang@cognition.ai>
- Add MIGRATION_NOTES.md summarizing Java 8 to 11 migration changes - Update README.md with Java 11 requirement Co-Authored-By: Cindy Huang <cindy.huang@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Java 8 to Java 11 Migration
Summary
This PR migrates the Springboot-BankApp from Java 8 to Java 11. Since the codebase was using Spring Boot 3.3.3 (which requires Java 17+), this migration required downgrading to Spring Boot 2.7.18 LTS (which supports Java 8-17).
Key changes:
<release>11</release>)jakarta.persistence→javax.persistenceReview & Testing Checklist for Human
isAccountNonExpired(),isAccountNonLocked(),isCredentialsNonExpired(),isEnabled()all returntrue. Verify this is acceptable for the application's security requirements.Recommended test plan:
bankappdbdatabasemvn spring-boot:runand verify application startsNotes
MIGRATION_NOTES.mdfor detailed documentation of all changesLink to Devin run: https://app.devin.ai/sessions/987a3100a2c64f59aeca25e3997e3199
Requested by: Cindy Huang (cindy.huang@cognition.ai) (@cindyyhuang)