Conversation
oftenfrequent
left a comment
There was a problem hiding this comment.
Seeing the syntax in practice brings up some thoughts.
-
The naming scheme for
propArrays vs argument accepted in the helper function.
A) Should the property be pluralmembersbut the helper functions be singularaddMemberand accept a coala-ip instance of person in this instance.
or
B) Should anypropArrayhelper functions accept only arrays containing at least 1 coala-ip instance without throwing an error.
I am partial to the latter. -
This helps us in the short term gain parity over our schema on the front end and db however I'm not sure it solves the issue fully enough. It seems as though we should migrate all
propArraysto the updated syntax for consistency's sake.
Let me know your thoughts.
|
Ah good catch! I meant to revisit that too. I like B and migrating the other propArrays as well. |
No description provided.