Fix method chatroom #165
Open
Fix method chatroom #165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… purged from a local category
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…, if note assertion is called via search; manual pull)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
only match [[namespace:key]] allow underscores,dashes and dots in namespace key add test
add tx string
fixes chat teasers and probably every other place where display name is shown
…efore being added
that explode rss module
@julianlam tried accepts module ran into issues when the route was requested via browser or via $.ajax with the default headers, for example accepts(req).type(activitypub._constants.acceptableTypes) still returns true when /post/123 is loaded via browser or via $.ajax
show fail count and sent count separately
fix paths in topic thumbs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issues related to high code complexity (branch went to depth 19). Also, fixed a minor safety issue in the request.js file, which would try to extract data that had not been safely cached yet.
The chatroom refactor file seems to migrate chats to a different database. My refactoring seems to be within the scope of this file and the scope of the request.js file. This is because requests can trigger chatroom refactoring.
The issue originally made it harder to identify bugs within the software. This is because there wasn't much modularity. I split the original function into 4 different functions. Each function performed a specific task, making it easier to read. The fixes I made make the code more modular and easier to follow. I considered alternatives such as shortening some lines of code, but it seemed like a poor approach, as reducing lines can make code harder to debug later on (if you are looking for a specific issue).
To trigger the refactored code, I clicked on the opened chats.