Refactor (src/messaging/index.js): resolve complex binary expression in getPublicRooms()

[Eugenehwng]

P1B: Starter Task: Refactoring PR

1. Issue

Link to Issue

Full path to the refactored file:
src/messaging/index.js

What do you think this file does?
This file is the entry point for the messaging module that builds the messaging object with methods that handles the logic for "chats" in nodebb.

What is the scope of your refactoring within that file?
1. Factored out the complex binary expression in getPublicRooms function, using a additional helper function "canUserAccessRoom" that checks user permisssions to see if there are any rooms the current user can access.

Which Qlty‑reported issue did you address?
Complex binary expression: line 139

2. Refactoring

How did the specific issue you chose impact the codebase’s maintainability?
The creation of the helper function "canUserAccessRoom" factors out the boolean logic of checking room access for a user, which enables the code to be more modular. Messaging functions now need to simply call the helper function to do this, which follows the DRY principle.

What changes did you make to resolve the issue?

1. Removed complex binary expression in the getPublicRooms function.
2. Created a new helper function "canUserAccessRoom" to handle this logic. (async function)
3. Replaced the complex binary expression in getPublicRooms to a simple function call to the newly created helper function.

How do your changes improve maintainability? Did you consider alternatives?
This improves the readability and modularity of the codebase. Alternatives considered were using intermediate variables within the binary expression, but this did not really reduce the complexity of it.

3. Validation

How did you trigger the refactored code path from the UI?

1. Log in
2. Click on the "chats" button (getPublicRooms() is called when user enters the /chats page).

Attach a screenshot of the logs and UI demonstrating the trigger.

Logs:

(you can seee that "Eugene" is printed to the console.)

Relevant UI:

qlty smells output:

(you can see that the "complex binary expression" report is no longer here).