Add FixDescriptor engine module integration#357
Draft
swapnilraj wants to merge 8 commits intoCMTA:masterfrom
Draft
Add FixDescriptor engine module integration#357swapnilraj wants to merge 8 commits intoCMTA:masterfrom
swapnilraj wants to merge 8 commits intoCMTA:masterfrom
Conversation
Propagate the new four-field ICMTATConstructor.Engine shape across deployment helpers and proxy/deployment tests so all initialization paths pass the FixDescriptor engine position explicitly. Co-authored-by: Cursor <cursoragent@cursor.com>
Expose token() on the engine interface and add a dedicated invalid-binding error, then guard setFixDescriptorEngine so only engines bound to the current CMTAT instance can be configured. Co-authored-by: Cursor <cursoragent@cursor.com>
Remove token-level assertions for engine-only read APIs, bind mock engines to the active token in valid paths, add zero-address setter coverage, and assert wrong-token engine binding reverts. Co-authored-by: Cursor <cursoragent@cursor.com>
Rebase the FixEngine work onto the upstream v3.2.0 module layout, keep FixDescriptor engine module integration and access control hooks intact, and adapt deployment/tests to the updated constructor engine shape. Co-authored-by: Cursor <cursoragent@cursor.com>
Remove explicit zero-address snapshot/document/fix engine init calls from CMTATBaseAccessControl so initialization flow matches CMTA v3.2 patterns while preserving role-gated FixDescriptor engine wiring. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FixDescriptorEngineModulewith storage, setter/getter APIs, and role-gated engine configurationCMTATBaseAccessControlTest plan
HARDHAT_CONFIG=.hardhat.nosize.config.js npx hardhat test test/standard/modules/FixDescriptorModule/FixDescriptorModule.test.js test/standard/modules/FixDescriptorModule/FixDescriptorModuleConstructor.test.js test/proxy/modules/FixDescriptorModule/FixDescriptorModule.test.js test/proxy/modules/FixDescriptorModule/FixDescriptorModuleConstructor.test.js test/standard/modules/CMTATIntegration.test.js test/proxy/modules/CMTATIntegration.test.jsMade with Cursor