Detect unreplaced placeholders #86
Merged
+306
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CSV headers definitions include placeholders: numbers for code and code type columns, and payer and plan names for CSV wide columns. Detect these placeholders when validating columns. When detected, return a PlaceholderError.
daniel-eckel
approved these changes
Jan 21, 2026
shaselton-usds
approved these changes
Jan 22, 2026
Collaborator
shaselton-usds
left a comment
shaselton-usds
left a comment
There was a problem hiding this comment.
Tests pass, looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CSV headers definitions include placeholders: numbers for code and code type columns, and payer and plan names for CSV wide columns. Detect these placeholders when validating columns. When detected, return a PlaceholderError.
I decided to go with a simpler implementation that detected the placeholders in separate functions, rather than trying to integrate the placeholder detection into
getPayersPlansandgetCodeCount. The result is a little bit of repeated iteration, but it is a small cost compared to the overall validation process.