BCDA-9715: Consolidate ECR #1302
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| echo "Ref is not a tag; setting version to revision shorthand" | ||
| REV_SHORT=$(git rev-parse --short=8 HEAD) | ||
| echo "version=$REV_SHORT" >> $GITHUB_OUTPUT | ||
| echo "version=temp-$REV_SHORT" >> $GITHUB_OUTPUT |
Contributor
There was a problem hiding this comment.
why add temp here?
Collaborator
Author
There was a problem hiding this comment.
Needed to allow for ECR policy to differentiate between release tags and feature branch/daily image tags.
bhagatparwinder
previously approved these changes
Jan 29, 2026
| docker image push ${{ env.ECR_URL }}:${{ steps.version.outputs.version }} | ||
| - name: Log into prod in order to push to prod ECR | ||
| uses: aws-actions/configure-aws-credentials@v4 | ||
| if: ${{ startsWith(steps.version.outputs.version, 'r') }} |
Contributor
There was a problem hiding this comment.
Nice! Adding the "temp-" prefix to non-tags lets us do neat checks like this!
…/bcda-app into carl-9715-consolidate-ecr
michaeljvaldes
approved these changes
Feb 2, 2026
laurenkrugen-navapbc
approved these changes
Feb 3, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://jira.cms.gov/browse/BCDA-9715
🛠 Changes
Adjust build and publish workflows to account for consolidation of ECR. Add prefix to git sha version tags.
ℹ️ Context
Part of the process of slimming down our ECR presence from repos per env to per account.
🧪 Validation
Will need to verify workflows once bcda-ops changes have been merged.