Add learn quant #67
Merged
Add learn quant #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanest
approved these changes
Jul 18, 2025
Collaborator
shanest
left a comment
shanest
left a comment
There was a problem hiding this comment.
Awesome, thanks for bringing this back Chris! Going to merge now, but just a couple small comments to discuss in the future that I think are vestiges from older versions of Meaning and the like
| """Get the complement of the meaning of this expression, i.e. the set of all referents for which | ||
| the expression evaluates to False.""" | ||
|
|
||
| return Meaning( |
Collaborator
There was a problem hiding this comment.
I think this is out of date with the new Meanings that are mappings, not just sets of referents. And also, if we do want this, it should be with Expression, not just GrammaticalExpression, since nothing depends on the grammatical structure
| self.meaning.universe, | ||
| ) | ||
|
|
||
| def draw_referent(self, complement=False): |
Collaborator
There was a problem hiding this comment.
Also should be part of Meaning or Expression, no?
| def __next__(self): | ||
| # Return the next rule in the iterator | ||
| # Raise StopIteration if there are no more rules | ||
| raise StopIteration |
Collaborator
There was a problem hiding this comment.
More sophisticated logic here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.