Skip to content

Add forecast tutorial #1193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
ValentinGebhart wants to merge 81 commits into
base: forecast-class
Choose a base branch
from
Draft

Add forecast tutorial #1193

ValentinGebhart wants to merge 81 commits into from

Conversation

@ValentinGebhart
Copy link
Collaborator

@ValentinGebhart ValentinGebhart commented Dec 10, 2025

Changes proposed in this PR:

  • Create forecast tutorial using ICON data and impact calc and different statistics

This PR fixes #

PR Author Checklist

PR Reviewer Checklist

peanutfun and others added 30 commits December 8, 2025 12:02
@peanutfun
Merge branch 'forecast-class' into impact-forecast-class
0901b4d
@peanutfun
Add ImpactForecast
b7b6545
@peanutfun
Add fixture for impact kwargs
3b077a0
@peanutfun
Use kwarg assignment in ImpactForecast.__init__
44bf09a
@peanutfun
Add test for ImpactForecast.select
347fcf1
@peanutfun
Merge branch 'forecast-class' into impact-forecast-select
01c138e
@peanutfun
Merge branch 'forecast-class' into impact-forecast-select
fe5d705
@luseverin
Return impactForecast object in _return_impact
7da50f1
@peanutfun
Fix merge issue
4d36a0d
@luseverin
Return impactForecast object in _return_empty
bd3502f
@Evelyn-M
minor test modification
78878b7
@luseverin
Add full impactcalc test for impactForecast
dfa0198
@luseverin
Correct mistakes in _return_empty and _return_impact
59c0e5b
@luseverin
Raise value error when computing impact with impact forecast without …
4b5ae95 
…saving impact matrix
Cosmetics: Improve error message, move test to own class
9a516e1
@luseverin
Merge branch 'forecast-class' into impactCalc_block_nonsense_attrs
d571bb7
@luseverin
Merge branch 'impactCalc_return_impactForecast' into impactCalc_block…
6fe29f0 
…_nonsense_attrs
@luseverin
add test to check that eai_exp and aai_agg are nan for forecasts
899d8f0
@luseverin
Write nans for eai_exp and aai_agg when forecast is used
db32170
@luseverin
update tests using pytest
d2f035f
@luseverin
Fix error in test fixtures
c10a4b3
@luseverin
Returns nans for eai_exp and aai_agg when exposures is empty
d3a5642
@luseverin
add warning when at_event is used with forecast
d43a46c
@peanutfun
Update ImpactCalc tests for forecasts
e197566
@peanutfun
Merge branch 'impactCalc_return_impactForecast' of https://github.com…
0a324b2 
…/CLIMADA-project/climada_python into impactCalc_return_impactForecast
@peanutfun
Review ImpactCalc forecast handling
554cfc8
@luseverin
Block local_exceedance_impact
30ed14d
@peanutfun
Fix bug in test
f3ab44a
@peanutfun
Merge branch 'impactCalc_return_impactForecast' of https://github.com…
612a53c 
…/CLIMADA-project/climada_python into impactCalc_return_impactForecast
@luseverin
Block return_period and exceedance_freq_curve
9e4f2bb
@ValentinGebhart ValentinGebhart marked this pull request as draft December 10, 2025 14:40
peanutfun and others added 21 commits December 10, 2025 15:56
@peanutfun
Merge branch 'forecast-class' into forecast-io
643edfa
@Evelyn-M
Merge branch 'forecast-io' of https://github.com/CLIMADA-project/clim…
7204e90 
…ada_python into add_forecast_tutorial
@peanutfun
Simplify data parsing and tests
96ccc58
@peanutfun
Merge branch 'forecast-class' into forecast-io
84b344b
@peanutfun
Restore test_impact_forecast.py
b5e7d7a
@luseverin
Correct wrong use of self.dim in mean min max
1076719
@Evelyn-M
continue OGD showcase
c4f06a6
@luseverin
Parametrize hazard fixtures with different members and lead times and…
bc6f576 
… continue drafting tests
@luseverin
Merge branch 'forecast-class' into implement_unique_selection_reduction
001f340
@ValentinGebhart
update tutorial
6e25208
@ValentinGebhart
Merge branch 'forecast-class' of github.com:CLIMADA-project/climada_p…
d84db1e 
…ython into forecast-class
@ValentinGebhart
Merge branch 'forecast-class' into add_forecast_tutorial
ec2948b
@ValentinGebhart
finalize tutorial (some statistics method to be checked)
3781391
@ValentinGebhart
update tutorial
4741fd0
@peanutfun
Skip tests for incompatible xarray versions
9685a81
@Evelyn-M
merge from io
db69a0f
@Evelyn-M
API data and cleaning of tutorial
e01c7d2
@Evelyn-M
TOC for notebook
0dc8644
@peanutfun
Adjust reduction logic with respect to members
5b46f63 
Tests are still failing!
@peanutfun
Merge branch 'implement_unique_selection_reduction' into add_forecast…
4f5e4e5 
…_tutorial
@peanutfun
Fix dimension reduction for HazardForecast
bb72db3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emanuel-schmid emanuel-schmid Awaiting requested review from emanuel-schmid emanuel-schmid is a code owner

@chahank chahank Awaiting requested review from chahank chahank is a code owner

@peanutfun peanutfun Awaiting requested review from peanutfun peanutfun is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ValentinGebhart @peanutfun @luseverin @Evelyn-M