Skip to content

Add hdf5 IO for ImpactForecast #1190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
peanutfun merged 4 commits into from
Dec 10, 2025
Merged

Add hdf5 IO for ImpactForecast #1190

peanutfun merged 4 commits into from
Dec 10, 2025

Conversation

@ValentinGebhart
Copy link
Collaborator

@ValentinGebhart ValentinGebhart commented Dec 10, 2025

Changes proposed in this PR:

  • adapt read_hdf5 and write_hdf5 in Impact base class to handle additional attributes
  • overwrite base class read_hdf5 in ImpactForecast
  • add test

This PR fixes #

PR Author Checklist

PR Reviewer Checklist

@peanutfun peanutfun merged commit 0e7857f into forecast-class Dec 10, 2025
12 of 14 checks passed
@emanuel-schmid emanuel-schmid deleted the add_io_hdf5_imp_forecast branch December 11, 2025 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peanutfun peanutfun peanutfun approved these changes

@emanuel-schmid emanuel-schmid Awaiting requested review from emanuel-schmid emanuel-schmid is a code owner

@chahank chahank Awaiting requested review from chahank chahank is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ValentinGebhart @peanutfun