Integrates risk trajectories within climada #1037
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Lukas Riedel <34276446+peanutfun@users.noreply.github.com>
Co-authored-by: Lukas Riedel <34276446+peanutfun@users.noreply.github.com>
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
Collaborator
Author
|
I created a discussion here #1039 |
- Replaced RiskPeriod class by CalcRiskPeriod class to centralize shared computations and dynamic metric instantiation. - Improved efficiency by reusing shared computations across metrics. - Added InterpolationStrategy and ImpactCalcStrategy classes to abstract that part of the computation
This reverts commit e48c924.
Collaborator
Author
|
Can I ask when you plan to continue and finish the review? |
chahank
reviewed
Nov 7, 2025
- Adds constants for columns name and other repeatedly used strings - Adds a reordering df columns function (also fixes column order inconsistencies) - Changes period AAI from sum to average - Fixes bugs when group_id not defined (also now returns None instead of empty df - Adds convenience function in Snapshot for ImpactCalc init - Now sorts snapshots list by date in base class - Now allows None for risk_disc_rates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
Implements
RiskTrajectoryobjects to ease the evaluation of risk / impact in between two points in time.See the associated discussion here: #1039
A notebook showcasing this new module is available in
doc/tutorial/climada_trajectory.ipynb. (It is not a real tutorial yet, but will serve as its basis).Also note that the future option appraisal module will be based on this.
Remaining TODO s
Snapshotby their date when instantiatingExposureshave the same shape within a risk trajectory.group_idare identical forExposuresor handle that case (Handled, different group_id are possible, metric is computed at each date and interpolated in between)PR Author Checklist
develop)PR Reviewer Checklist