Fix unclosed delimiter error handling #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes bug of incorrect unclosed delimiter error handling:
FinalErroris ignored inParser.parse(), and other exceptions are reported as internal errors. (commit 00c7de5)unclosedDelimiterErrormay causeIndexOutOfBoundsexception because there unexpectedConsumeErrors are caught and handled as unclosed delimiter errors (where the cosume error comes from something else, e.g. failure to consume an identifier). It's now fixed by adding more consume error handling and shrinkingtryblocks to include only the expectedhelper.consume()call. (in commit 02e6c0d)helper.previousNonNLTokenWithIndex()method to obtain the correct opening delimiter token. (also in commit 02e6c0d)ErrorUnclosedDelimiterwith an error message pointing to the unclosed opening delimiter and an info message showing the current token where the parser finds that the opening delimiter should have been (but isn't) closed. (commit f33581d)