Merged
Conversation
Build against QtC 17
Qt Creator 17 has a different signature to the initialize method. I removed the pointer to the error string and fixed the return value type. The return value is changed to Ok (was true before).
The virtual initialize(...) method was changed in it's signature by Qt for QtCreator. Because the implementation of the virtual method was not marked override, it was not detected, that his method was not called anymore. This is now changed for the three interface methods.
Adapted initialize method to new signature
The connection to the signal cursorPositionChanged was failing, because the editor widget type changed to TextEditor::TextEditorWidget. The qdynamic_cast delivered a null pointer, so that changes of the cursor were not processed anymore.
Editor->widget has type TextEditor::TextEditorWidget
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.