Open
Conversation
451f7b6 to
16dd93f
Compare
16dd93f to
9182022
Compare
In preparation to add CheckIndentifiers, this mode needs to be removed.
9182022 to
06bf506
Compare
Contributor
Author
|
With some projects it crashes on loading: ASSERT: "m_isLocked" in file /usr/include/qt6/QtCore/qmutex.h, line 249 |
Owner
|
Does it also crash on the same projects with the |
Contributor
Author
|
No, it does not. But there are not many comments in the project that makes it crash. |
Contributor
Author
|
Looked into the code to find and I don't understand the logic there. Here is the simplified fragment: QMutexLocker locker( &d->futureMutex );
...
if (/*condition*/) { // (1)
...
locker.unlock(); // (2)
...
}
locker.unlock() // (3)Why is it manually unlocked at (3)? At (2)? And of course now it it obvious why is assert triggered when the condition at (1) is true. I'd remove both manual unlock() calls? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an option and test for identifier tokens.
Closes #56.