Quality of life improvements

[magik6k]

• Makefile
• gwcfg util for env config management
• Misc fixes

[Copilot]

Pull Request Overview

This PR introduces several quality‐of‐life improvements including refactoring of wallet imports, external offload modules, and adjustments to configuration defaults and server setup. Key changes include:

• Removal and refactoring of legacy S3 offload functions in favor of new external module implementations.
• Modification of internal state types (e.g. activeUploads now counts in an integer) and adjustments to configuration defaults (e.g. transfer idle timeout and max retries).
• Updates to the car server and external HTTP paths to support TLS and built-in server functionality.

Reviewed Changes

Copilot reviewed 14 out of 18 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
ributil/wallet.go	Removed inline comment for secp signatures; minor cosmetic update.
rbdeal/ribs.go	Changed type for activeUploads and refactored wallet creation logic along with the car server call.
rbdeal/group_deal.go	Removed S3 offload call in favor of external offload push.
rbdeal/external_s3.go	Refactored S3 offload handling via S3OffloadInfo structure and introduced a TODO for URL retrieval.
rbdeal/external_http_path.go	Added implementation of LocalWeb external push and read functionality.
rbdeal/external.go	Adjusted external module interface usages and error messaging.
rbdeal/deal_tracker.go	Removed S3 offload cleanup call, streamlined external offload cleanup.
rbdeal/deal_params.go	Updated transfer idle timeout and max transfer retries values.
rbdeal/deal_db.go	Removed legacy S3 offload DB functions, with a TODO for migration.
rbdeal/car_server.go	Updated server TLS setup and revised handling for direct HTTP transfers.
configuration/config.go	Updated Localweb and S3 configuration with new environment variables and default values.

Files not reviewed (4)

• Makefile: Language not supported
• go.mod: Language not supported
• go.work: Language not supported
• go.work.sum: Language not supported

Comments suppressed due to low confidence (3)

ributil/wallet.go:21

• [nitpick] Consider restoring or clarifying the removed comment explaining why the 'secp' package is imported, to signal that it registers the secp signatures.

_ "github.com/filecoin-project/lotus/lib/sigs/secp"

rbdeal/ribs.go:257

• Changing 'activeUploads' from a map with empty struct values to a map with integers alters its semantics; please verify that the increment/decrement logic correctly reflects the intended concurrent upload count.

activeUploads:   map[uuid.UUID]int{},

rbdeal/deal_params.go:46

• The increase of transferIdleTimeout from 5 minutes to 120 minutes and maxTransferRetries from 10 to 10000 is significant; please confirm these new defaults are intentional as they may impact performance and retry behavior.

var transferIdleTimeout = 120 * time.Minute