Skip to content

Comments

fix #34 pull frame medatada file#37

Merged
sphamba merged 3 commits intodevfrom
feat/pull-frame-medatada-file
Oct 23, 2025
Merged

fix #34 pull frame medatada file#37
sphamba merged 3 commits intodevfrom
feat/pull-frame-medatada-file

Conversation

@sphamba
Copy link
Collaborator

@sphamba sphamba commented Oct 23, 2025

Describe your changes

Checklist before requesting a review

  • I have performed a self-review of my code
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • Don't forget to link PR to issue if you are solving one.

@sphamba sphamba requested a review from Copilot October 23, 2025 14:52
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses issue #34 by implementing functionality to pull frame metadata files. The changes remove unused local show and list functions while adding proper metadata file downloading during model pulls.

Key changes:

  • Added pull_metadata_file() function to download FRAME metadata files from the API during model pulls
  • Removed unimplemented local model/component show and list functions
  • Replaced print statements with logger calls for better logging consistency

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
frame_cli/pull.py Implements metadata file downloading and updates logging to use logger instead of print
frame_cli/metadata.py Adds metadata_file_exists() helper and updates error handling to support non-git directories
frame_cli/show.py Removes unimplemented show_local_model() and show_local_component() functions
frame_cli/main.py Removes local options from show commands that are no longer supported
frame_cli/listing.py Removes unimplemented list_local_components() function

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@sphamba sphamba merged commit 60afdd6 into dev Oct 23, 2025
8 checks passed
@sphamba sphamba deleted the feat/pull-frame-medatada-file branch October 23, 2025 15:08
@sphamba sphamba mentioned this pull request Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant