Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements the pulling functionality for components and refactors common API retrieval logic. The changes remove the incomplete local component listing feature and consolidate duplicate code for retrieving model/component information from the API.
Key changes:
- Extracted common API retrieval logic for models and components into reusable utility functions
- Implemented the
pull componentcommand to download components from remote repositories - Removed unimplemented local component listing functionality
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| frame_cli/utils.py | Added retrieve_model_info() and retrieve_component_info() functions to centralize API retrieval logic |
| frame_cli/show.py | Refactored to use new utility functions instead of duplicating API call logic |
| frame_cli/pull.py | Moved retrieve_model_info() to utils and implemented pull_component() function |
| frame_cli/main.py | Updated CLI arguments to remove local model path requirement and add local/remote flags |
| frame_cli/listing.py | Changed unimplemented feature message from "not yet" to final state |
| frame_cli/config.py | Suppressed dotenv verbose output using context managers |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement pulling component.
remove possibility of listing local components (was not implemented)
fix [BUG] Hide pull command for components if repo is same as model frame-project#41
Checklist before requesting a review
fix #xxx[,#xxx], where "xxx" is the issue number)