Skip to content

Comments

feat: pull component#36

Merged
sphamba merged 3 commits intodevfrom
fix/component-pull-command
Oct 23, 2025
Merged

feat: pull component#36
sphamba merged 3 commits intodevfrom
fix/component-pull-command

Conversation

@sphamba
Copy link
Collaborator

@sphamba sphamba commented Oct 23, 2025

Implement pulling component.

Checklist before requesting a review

  • I have performed a self-review of my code
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • Don't forget to link PR to issue if you are solving one.

@sphamba sphamba requested a review from Copilot October 23, 2025 13:01
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements the pulling functionality for components and refactors common API retrieval logic. The changes remove the incomplete local component listing feature and consolidate duplicate code for retrieving model/component information from the API.

Key changes:

  • Extracted common API retrieval logic for models and components into reusable utility functions
  • Implemented the pull component command to download components from remote repositories
  • Removed unimplemented local component listing functionality

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
frame_cli/utils.py Added retrieve_model_info() and retrieve_component_info() functions to centralize API retrieval logic
frame_cli/show.py Refactored to use new utility functions instead of duplicating API call logic
frame_cli/pull.py Moved retrieve_model_info() to utils and implemented pull_component() function
frame_cli/main.py Updated CLI arguments to remove local model path requirement and add local/remote flags
frame_cli/listing.py Changed unimplemented feature message from "not yet" to final state
frame_cli/config.py Suppressed dotenv verbose output using context managers

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@sphamba sphamba merged commit a4fed90 into dev Oct 23, 2025
8 checks passed
@sphamba sphamba deleted the fix/component-pull-command branch October 23, 2025 13:03
@sphamba sphamba mentioned this pull request Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant