Skip to content

DB: fix access to master buffers during DP insertion #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xsedla1o merged 2 commits into from
Sep 16, 2025
Merged

DB: fix access to master buffers during DP insertion #30

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be88a99
DB: fix access to master buffers during DP insertion
dbnk0 Sep 9, 2025
9e8ca9d
DB: refactor access to master buffers during DP insertion
dbnk0 Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions dp3/database/database.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,10 +424,13 @@ def insert_datapoints(
with self._master_buffer_locks[etype]:
if eid in self._master_buffers[etype]:
for attr, push_dps in master_changes["pushes"].items():
if attr in self._master_buffers[etype][eid]["pushes"]:
self._master_buffers[etype][eid]["pushes"][attr].extend(push_dps)
else:
self._master_buffers[etype][eid]["pushes"][attr] = push_dps
if "pushes" not in self._master_buffers[etype][eid]:
self._master_buffers[etype][eid]["pushes"] = {}
if attr not in self._master_buffers[etype][eid]["pushes"]:
self._master_buffers[etype][eid]["pushes"][attr] = []
self._master_buffers[etype][eid]["pushes"][attr].extend(push_dps)
if "$set" not in self._master_buffers[etype][eid]:
self._master_buffers[etype][eid]["$set"] = {}
self._master_buffers[etype][eid]["$set"].update(master_changes["$set"])
else:
self._master_buffers[etype][eid] = master_changes
Expand Down