-
Notifications
You must be signed in to change notification settings - Fork 1
BibAuthority: people collection #162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: prod
Are you sure you want to change the base?
BibAuthority: people collection #162
Conversation
0747b1c to
cb216c3
Compare
99b5de6 to
ed92a1d
Compare
ed92a1d to
075d342
Compare
075d342 to
b25bbbd
Compare
|
Do diff with production code before merging |
| author in query_author_source("") if | ||
| author.get("cernccid") and author.get("inspireid") | ||
| ] | ||
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be changed somehow, we shouldn't have complex function calls inside a config file specially if they relay in external services which might or might not work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you can use this to build the dictionary https://github.com/CERNDocumentServer/invenio/blob/prod/modules/miscutil/lib/containerutils.py#L280
| pass | ||
|
|
||
|
|
||
| class Mapper: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe is better to use new style classes https://docs.python.org/2/reference/datamodel.html#new-style-and-classic-classes
4471130 to
4cdeab9
Compare
* Adds config, mapper, and utils which are used by the command line interface (CLI) 'bibauthority_people' and the bibsched tasklet 'bst_bibauthority_people_updater'. Signed-off-by: Jochen Klein <j.klein@cern.ch>
* Adds a command line interface for mapping all CERN LDAP records to MARC 21 authority records, writing to MARCXML, and uploading to CDS. * Adds CLI to makefile. Signed-off-by: Jochen Klein <j.klein@cern.ch>
* Adds bibsched tasklet which updates the CERN people collection on CDS. * Adds tasklet to makefile. Signed-off-by: Jochen Klein <j.klein@cern.ch>
4cdeab9 to
b077038
Compare
|
I see a lot of references to CERN. Can you confirm that this shall not be an invenio PR? @egabancho @switowski |
|
Confirmed, but I don't remember why I wrote this "note to self" |
Adds a command line interface and bibsched tasklet to create and update the CERN people collection used by CDS. (Requires #140)