Skip to content

sync: persist into db at each change #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jrcastro2 merged 1 commit into from
Dec 2, 2024
Merged

sync: persist into db at each change #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions invenio_cern_sync/groups/sync.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ def sync(**kwargs):
log_uuid=log_uuid,
)
roles_ids = create_or_update_roles(_serialize_groups(groups))
# db.session.commit() happens inside create_or_update_roles
log_info(
log_name,
dict(
Expand Down
5 changes: 2 additions & 3 deletions invenio_cern_sync/users/sync.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,10 +162,9 @@ def _update_existing(users, serializer_fn, log_uuid, log_name):
), f"User and UserIdentity are not correctly linked for user #{user.id} and user_identity #{user_identity.id}"

if update_existing_user(user, user_identity, invenio_user):
db.session.commit()
updated.add(user.id)

# persist changes before starting with the inserting of missing users
db.session.commit()
log_info(
log_name,
dict(action=log_action, status="completed", updated_count=len(updated)),
Expand Down Expand Up @@ -195,9 +194,9 @@ def _insert_missing(invenio_users, log_uuid, log_name):
f"Error creating user from CERN data: {e}. Skipping this user... User: {invenio_user}"
)
continue
db.session.commit()
inserted.add(_id)

db.session.commit()
log_info(
log_name,
dict(action=log_action, status="completed", inserted_count=len(inserted)),
Expand Down