add(clc sync): link to remove sync #649
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntarocco
reviewed
Dec 11, 2025
| as="a" | ||
| onClick={(e) => { | ||
| e.preventDefault(); | ||
| if (!loading) { |
Contributor
There was a problem hiding this comment.
this shouldn't be needed given the disabled below. And why the preventDefault?
Contributor
Author
There was a problem hiding this comment.
I realized my assets watch was not working well... so it's not looks like that at the moment sorry :(
with Button it looks like this and no need topreventDefault:
And if we want to use <a> so it'll look like a text button, than we need preventDefault
Contributor
Author
There was a problem hiding this comment.
Or maybe we can add it here?
Contributor
There was a problem hiding this comment.
What about only the trash bin red icon, to keep it small?
Contributor
Author
There was a problem hiding this comment.
I hope it's good like this :) And do we need the hint?
zubeydecivelek
force-pushed
the
remove-clc-sync
branch
from
e70ca51 to
4dfe8e5
Compare
zubeydecivelek
force-pushed
the
remove-clc-sync
branch
from
4dfe8e5 to
10d14d7
Compare
ntarocco
approved these changes
Dec 11, 2025
zzacharo
approved these changes
Dec 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only added to UI:
Backend, tests were already implemented.