Skip to content

names vocab: add inspire and lcds schema #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kpsherva wants to merge 2 commits into from
Closed

names vocab: add inspire and lcds schema #276

kpsherva wants to merge 2 commits into from

Conversation

@kpsherva
Copy link
Contributor

@kpsherva kpsherva commented Dec 2, 2024

kpsherva
kpsherva commented Dec 3, 2024
View reviewed changes
site/cds_rdm/tasks.py
User.updated > since,
User.active == True,
).all()
if since:
Copy link
Contributor Author

@kpsherva kpsherva Dec 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jrcastro2 is this ok? the task didn't work with since = None

Copy link
Contributor

@jrcastro2 jrcastro2 Dec 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! I would simply update the logging as well to be more clear:

if since:
        current_app.logger.debug(
            f"Names sync | Fetching active users updated since {since}."
        )
        ...
else:
        current_app.logger.debug(
            f"Names sync | Fetching all active users."
        )
        ...

zzacharo
zzacharo reviewed Dec 3, 2024
View reviewed changes
invenio.cfg Outdated
**DEFAULT_VOCABULARIES_NAMES_SCHEMES,
"cern": {"label": _("CERN"), "validator": schemes.is_cern, "datacite": "CERN"},
"lcds": {"label": _("CDS"), "validator": schemes.is_cern, "datacite": "CDS"},
"inspire": {"label": _("Inspire"), "validator": schemes.is_cern, "datacite": "INSPIRE"},
Copy link
Contributor

@zzacharo zzacharo Dec 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be using is_inspire?

kpsherva
kpsherva commented Dec 3, 2024
View reviewed changes
@zzacharo zzacharo mentioned this pull request Dec 3, 2024
Merged
@kpsherva kpsherva closed this Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jrcastro2 jrcastro2 jrcastro2 left review comments

@zzacharo zzacharo zzacharo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

hook up the names vocab

3 participants

@kpsherva @jrcastro2 @zzacharo