legacy: Add redirection for collections #261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntarocco
reviewed
Nov 19, 2024
sakshamarora1
force-pushed
the
feature/legacy_redirect_collections
branch
2 times, most recently
from
2a8d5f0 to
1c16a2d
Compare
sakshamarora1
force-pushed
the
feature/legacy_redirect_collections
branch
from
1c16a2d to
1c7ed8e
Compare
Contributor
Author
|
Tests will fail until inveniosoftware/invenio-app-rdm#2923 is deployed. Otherwise will need to revert last commit (use g.identity and duplicate error handlers) |
kpsherva
reviewed
Nov 25, 2024
kpsherva
reviewed
Nov 25, 2024
kpsherva
reviewed
Nov 25, 2024
kpsherva
reviewed
Nov 25, 2024
Contributor
|
@sakshamarora1 can you update the pipfile with the released https://github.com/inveniosoftware/invenio-app-rdm/releases/tag/v13.0.0b1.dev19 ? |
sakshamarora1
force-pushed
the
feature/legacy_redirect_collections
branch
2 times, most recently
from
131ca89 to
57614cb
Compare
zzacharo
approved these changes
Nov 26, 2024
Contributor
zzacharo
left a comment
zzacharo
left a comment
There was a problem hiding this comment.
A small comment about query params on collections but I am ok to create a separate issue for that.
sakshamarora1
force-pushed
the
feature/legacy_redirect_collections
branch
from
57614cb to
82d1494
Compare
ntarocco
reviewed
Nov 27, 2024
ntarocco
reviewed
Nov 27, 2024
site/cds_rdm/legacy/redirector.py
Outdated
| """ | ||
| # Fetch current collection if it exists | ||
| collection_name = request.args.get("cc", None) | ||
| # If not, then fetch from collection list, URLs with only single 'c' will be redirected for now |
Contributor
There was a problem hiding this comment.
can you make this comment more clear please?
sakshamarora1
force-pushed
the
feature/legacy_redirect_collections
branch
from
82d1494 to
fe8cad2
Compare
sakshamarora1
force-pushed
the
feature/legacy_redirect_collections
branch
from
fe8cad2 to
0891117
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #213