Update to Node 18.15 by jpandersen87 · Pull Request #8631 · CDCgov/prime-reportstream

jpandersen87 · 2023-03-07T02:04:46Z

Fixes #7078

This PR updates the required node version to 18.15.

Fixes #7078

snesm

Please update frontend-react/README.md as well.

jpandersen87 · 2023-03-07T16:25:34Z

Please update frontend-react/README.md as well.

Thanks for the reminder. Knew my 16.19.2 replace-all missed something!

github-actions · 2023-03-07T16:36:41Z

Test Results

760 tests ±0 756 ✔️ ±0 1m 6s ⏱️ -12s
  94 suites ±0     4 💤 ±0
  94 files ±0     0 ❌ ±0

Results for commit 99ed291. ± Comparison against base commit 56bac26.

♻️ This comment has been updated with latest results.

github-actions · 2023-03-07T16:44:48Z

Integration Test Results

124 tests 124 ✔️ 2m 1s ⏱️
  12 suites     0 💤
  12 files     0 ❌

Results for commit 99ed291.

♻️ This comment has been updated with latest results.

stephenkao · 2023-03-07T19:02:54Z

.github/actions/build-frontend/action.yml

      uses: actions/setup-node@64ed1c7eab4cce3362f8c340dee64e5eaeef8f7c
      with:
-        node-version: "16.19.1"
+        node-version: "18.14.2"


I wonder if we can just use node-version-file so we can just maintain the version in .nvmrc instead of having to keep this updated as well.

@JosiahSiegel feasible?

If devops approves, I feel this would be the right way to go.

Also, according to the docs (see: https://github.com/actions/setup-node/blob/main/docs/advanced-usage.md#node-version-file) it can read the engines.node property in package.json so the .nvmrc file may not be needed.

Oh, fantastic! Anything automatic like this would be the way to go in my opinion 🙏

stephenkao · 2023-03-07T19:06:00Z

Blech, I'm still running into the proxy issue wherein all requests to localhost:7071 are refused. BUT it works if I update proxy in package.json to http://127.0.0.1:7071 so maybe we can just update to that (or http://0.0.0.0:7071 for Docker) for a more explicit local IP address?

@etanb @penny-lischer Out of curiosity, do you run into this issue with the new version of Node?

frontend-react/src/components/MessageTracker/MessageReceivers.tsx

…rime-reportstream into experience/7078/node-18 merge

.github/actions/build-frontend/action.yml

stephenkao

Looking good to me! Any reason this can't be taken out of draft?

JosiahSiegel

I am creating a PR to update the action based on frontend-react/.nvmrc.
~~Please remove the action.yml change here, but proceed with the rest.~~

Change is required for the current action to succeed

stephenkao · 2023-03-10T16:51:07Z

Blech, I'm still running into the proxy issue wherein all requests to localhost:7071 are refused. BUT it works if I update proxy in package.json to http://127.0.0.1:7071 so maybe we can just update to that (or http://0.0.0.0:7071 for Docker) for a more explicit local IP address?

@etanb @penny-lischer Out of curiosity, do you run into this issue with the new version of Node?

@jpandersen87 I'm still running into the proxy error even with the latest minor version bump. What are your thoughts about updating that to be an explicit 127.0.0.1 or 0.0.0.0 instead of localhost? Shouldn't adversely affect anything 🤷

…rime-reportstream into experience/7078/node-18

jpandersen87 · 2023-03-10T17:09:24Z

Blech, I'm still running into the proxy issue wherein all requests to localhost:7071 are refused. BUT it works if I update proxy in package.json to http://127.0.0.1:7071 so maybe we can just update to that (or http://0.0.0.0:7071 for Docker) for a more explicit local IP address?
@etanb @penny-lischer Out of curiosity, do you run into this issue with the new version of Node?

@jpandersen87 I'm still running into the proxy error even with the latest minor version bump. What are your thoughts about updating that to be an explicit 127.0.0.1 or 0.0.0.0 instead of localhost? Shouldn't adversely affect anything 🤷

Explicit ip address commit pushed

sonarqubecloud · 2023-03-10T17:17:06Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

stephenkao

Looks great to me!

* Update to Node 18 Fixes #7078

* 8395 [Manage Public Key] Add new route, and basic page * 8395 [Manage Public Key] Add new route, and basic page * 8098 generate condition filtered FHIR bundle (#8600) * Added ability to remove filtered conditions from a bundle --------- Co-authored-by: Jessica Willis <jessicawillis@navapbc.com> * Update to Node 18.15 (#8631) * Update to Node 18 Fixes #7078 * 8395 [Manage Public Key] - Changed <div> to <GridContainer>. - Removed extra <div> * 8395 [Manage Public Key] - Fix lint error --------- Co-authored-by: victor-chaparro <117938212+victor-chaparro@users.noreply.github.com> Co-authored-by: Jessica Willis <jessicawillis@navapbc.com> Co-authored-by: Joseph Andersen <josephandersen@navapbc.com> Co-authored-by: Stephen Nesman <94193373+snesm@users.noreply.github.com>

* Update to Node 18 Fixes #7078

Update to Node 18

4ffa5a1

Fixes #7078

jpandersen87 requested review from etanb, penny-lischer and stephenkao March 7, 2023 02:04

jpandersen87 temporarily deployed to staging March 7, 2023 02:05 — with GitHub Actions Inactive

snesm suggested changes Mar 7, 2023

View reviewed changes

docs

923d1e6

jpandersen87 temporarily deployed to staging March 7, 2023 16:25 — with GitHub Actions Inactive

docs

a1be31a

jpandersen87 temporarily deployed to staging March 7, 2023 16:28 — with GitHub Actions Inactive

Merge branch 'master' into experience/7078/node-18

ae1e800

jpandersen87 temporarily deployed to staging March 7, 2023 16:29 — with GitHub Actions Inactive

stephenkao reviewed Mar 7, 2023

View reviewed changes

frontend-react/src/components/MessageTracker/MessageReceivers.tsx Outdated Show resolved Hide resolved

jpandersen87 added 2 commits March 9, 2023 11:13

revert string changes due to 18.15

ae6fa49

Merge branch 'experience/7078/node-18' of https://github.com/CDCgov/p…

45a448f

…rime-reportstream into experience/7078/node-18 merge

jpandersen87 temporarily deployed to staging March 9, 2023 17:19 — with GitHub Actions Inactive

jpandersen87 changed the title ~~Update to Node 18.14.2~~ Update to Node 18.15 Mar 9, 2023

Merge branch 'master' into experience/7078/node-18

96b3527

jpandersen87 temporarily deployed to staging March 9, 2023 17:22 — with GitHub Actions Inactive

18.15

cdb828b

jpandersen87 temporarily deployed to staging March 9, 2023 17:24 — with GitHub Actions Inactive

typo

d524da1

jpandersen87 temporarily deployed to staging March 9, 2023 17:25 — with GitHub Actions Inactive

stephenkao reviewed Mar 9, 2023

View reviewed changes

.github/actions/build-frontend/action.yml Show resolved Hide resolved

stephenkao reviewed Mar 9, 2023

View reviewed changes

jpandersen87 marked this pull request as ready for review March 9, 2023 19:30

jpandersen87 requested a review from a team as a code owner March 9, 2023 19:30

JosiahSiegel previously requested changes Mar 10, 2023

View reviewed changes

JosiahSiegel mentioned this pull request Mar 10, 2023

GItHub workflow read node version from file #8675

Closed

snesm requested review from JosiahSiegel and snesm March 10, 2023 15:55

snesm approved these changes Mar 10, 2023

View reviewed changes

Merge branch 'master' into experience/7078/node-18

a192b20

snesm temporarily deployed to staging March 10, 2023 16:05 — with GitHub Actions Inactive

JosiahSiegel approved these changes Mar 10, 2023

View reviewed changes

jpandersen87 added 2 commits March 10, 2023 11:08

use explicit loopback ip address for proxy

5bef3b2

Merge branch 'experience/7078/node-18' of https://github.com/CDCgov/p…

99ed291

…rime-reportstream into experience/7078/node-18

jpandersen87 temporarily deployed to staging March 10, 2023 17:08 — with GitHub Actions Inactive

stephenkao approved these changes Mar 10, 2023

View reviewed changes

jpandersen87 merged commit b9f927e into master Mar 10, 2023

jpandersen87 deleted the experience/7078/node-18 branch March 10, 2023 17:34

penny-lischer pushed a commit that referenced this pull request Mar 10, 2023

Update to Node 18.15 (#8631)

22b36ce

* Update to Node 18 Fixes #7078

penny-lischer pushed a commit that referenced this pull request Mar 15, 2023

Update to Node 18.15 (#8631)

4b13011

* Update to Node 18 Fixes #7078

Conversation

jpandersen87 commented Mar 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

snesm left a comment

Choose a reason for hiding this comment

Uh oh!

jpandersen87 commented Mar 7, 2023

Uh oh!

github-actions bot commented Mar 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

github-actions bot commented Mar 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Integration Test Results

Uh oh!

stephenkao Mar 7, 2023

Choose a reason for hiding this comment

Uh oh!

snesm Mar 7, 2023

Choose a reason for hiding this comment

Uh oh!

jpandersen87 Mar 7, 2023

Choose a reason for hiding this comment

Uh oh!

jpandersen87 Mar 7, 2023

Choose a reason for hiding this comment

Uh oh!

stephenkao Mar 7, 2023

Choose a reason for hiding this comment

Uh oh!

stephenkao commented Mar 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stephenkao left a comment

Choose a reason for hiding this comment

Uh oh!

JosiahSiegel left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stephenkao commented Mar 10, 2023

Uh oh!

jpandersen87 commented Mar 10, 2023

Uh oh!

sonarqubecloud bot commented Mar 10, 2023

Uh oh!

stephenkao left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

jpandersen87 commented Mar 7, 2023 •

edited

Loading

github-actions bot commented Mar 7, 2023 •

edited

Loading

github-actions bot commented Mar 7, 2023 •

edited

Loading

stephenkao commented Mar 7, 2023 •

edited

Loading

JosiahSiegel left a comment •

edited

Loading