Skip to content

Organization tests#3053

Open
krista-skylight wants to merge 13 commits intomainfrom
organization-tests
Open

Organization tests#3053
krista-skylight wants to merge 13 commits intomainfrom
organization-tests

Conversation

@krista-skylight
Copy link

@krista-skylight krista-skylight commented Mar 6, 2026

Description

New organization tests copied over from NEDSSDev

Tickets

Checklist before requesting a review

  • PR focuses on a single story
  • Code has been fully tested to meet acceptance criteria
  • PR is reasonably small and reviewable (Generally less than 10 files and 500 changed lines)
  • All new functions/classes/components reasonably small
  • Functions/classes/components focused on one responsibility
  • Code easy to understand and modify (clarity over concise/clever)
  • PRs containing TypeScript follow the Do's and Don'ts
  • PR does not contain hardcoded values (Uses constants)
  • All code is covered by unit or feature tests

@krista-skylight krista-skylight self-assigned this Mar 6, 2026
@krista-skylight krista-skylight requested a review from a team as a code owner March 6, 2026 18:38
@krista-skylight krista-skylight requested review from JordanGuinn and emyl3 and removed request for a team March 6, 2026 18:38
Copy link
Contributor

@JordanGuinn JordanGuinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still looks good to me! 🚀

- name: Checkout
uses: actions/checkout@v6

- name: Clean up old containers and volumes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(thought, nb): We could also perform this as a sort of clean-up task at the end of the workflow if we were inclined to? Similar to how the Python & Cypress e2e test workflows in NEDSSDev operate.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh good idea! also i'm glad you are ok with this. i really only added it in there because i'm having trouble figuring out why this test won't pass on CI and I thought it might be because it needs a fresh database. that said, i'm not going to merge this until i can figure out why.

@krista-skylight krista-skylight mentioned this pull request Mar 10, 2026
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants