Skip to content

CNFT1-3223: Remove handling of blur event to prevent persistent error display (PR preview) #2962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
joeaxcdw wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

CNFT1-3223: Remove handling of blur event to prevent persistent error display (PR preview) #2962

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d54b6e
Remove handling of blue event to prevent persistent error display
joeaxcdw Sep 17, 2025
8bbc845
Unit test for status checkbox blur behavior
joeaxcdw Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions apps/modernization-ui/src/apps/search/patient/PatientCriteria/BasicInformation.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,17 +4,16 @@ import { FormProvider, useForm } from 'react-hook-form';
import { BasicInformation } from './BasicInformation';
import { PatientCriteriaEntry } from '../criteria';
import { SkipLinkProvider } from 'SkipLink/SkipLinkContext';
import { error } from 'console';

const mockAllows = jest.fn();

jest.mock('libs/permission/usePermissions', () => ({
usePermissions: () => ({ permissions: [], allows: mockAllows })
}));

const Fixture = () => {
const Fixture = ({ mode }: { mode?: 'onChange' | 'onBlur' }) => {
const form = useForm<PatientCriteriaEntry>({
mode: 'onChange',
mode: mode ?? 'onChange',
defaultValues: { status: [{ name: 'Active', label: 'Active', value: 'ACTIVE' }] }
});

Expand Down Expand Up @@ -79,4 +78,20 @@ describe('when Basic information renders', () => {
expect(errorMessage).toHaveTextContent('The Date of birth should have a month between');
expect(errorMessage).toHaveTextContent('The Date of birth should be at least');
});

it('should not show an error message when unchecking all status boxes then tabbing to next checkbox', async () => {
mockAllows.mockReturnValue(true);
const { getByRole, queryByRole } = render(<Fixture mode="onBlur" />);

const user = userEvent.setup();

const statusCheckbox = getByRole('checkbox', { name: 'Active' });
expect(statusCheckbox).toBeChecked();
await user.click(statusCheckbox);
expect(statusCheckbox).not.toBeChecked();
await user.tab();

const errorMessage = queryByRole('alert');
expect(errorMessage).not.toBeInTheDocument();
});
});
3 changes: 1 addition & 2 deletions apps/modernization-ui/src/apps/search/patient/PatientCriteria/BasicInformation.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ export const BasicInformation = ({ sizing, orientation }: EntryFieldsProps) => {
rules={{
required: { value: true, message: 'At least one status is required' }
}}
render={({ field: { onChange, onBlur, value, name }, fieldState: { error } }) => (
render={({ field: { onChange, value, name }, fieldState: { error } }) => (
<CheckboxGroup
name={name}
label={'Include records that are'}
Expand All @@ -127,7 +127,6 @@ export const BasicInformation = ({ sizing, orientation }: EntryFieldsProps) => {
options={statusOptions}
value={value}
onChange={onChange}
onBlur={onBlur}
error={error?.message}
/>
)}
Expand Down