Err/app 311/resolve rtr incorrect lab rpt last update by#677
Merged
eliSkylight merged 13 commits intomainfrom Mar 2, 2026
Merged
Err/app 311/resolve rtr incorrect lab rpt last update by#677eliSkylight merged 13 commits intomainfrom
eliSkylight merged 13 commits intomainfrom
Conversation
…sting new functionality; new README in post processing service
eliSkylight
requested review from
hawley-skylight,
mehansen,
mpeels and
nullflux
…lt_observation_uid; only obsCache should have it
Temporarily changing the command for running tests
mpeels
reviewed
Feb 26, 2026
mpeels
reviewed
Feb 26, 2026
...a/gov/cdc/etldatapipeline/postprocessingservice/service/PostProcessingServiceEntityTest.java
Outdated
Show resolved
Hide resolved
ericbuckley
reviewed
Feb 26, 2026
...c/main/java/gov/cdc/etldatapipeline/postprocessingservice/service/PostProcessingService.java
Show resolved
Hide resolved
…y' of github.com:CDCgov/NEDSS-DataReporting into err/APP-311/resolve-rtr-incorrect-lab_rpt_last_update_by
mpeels
approved these changes
Feb 27, 2026
Contributor
mpeels
left a comment
mpeels
left a comment
There was a problem hiding this comment.
Test and build succeed locally. I will spend some time today looking into why the test is failing in Github.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes
The change extracts the Result observation uid from the Order observation payload in the post processing service. The conditions are that the incoming uid in the event message belongs to the Order record, it is a Lab Report, and it's an ELR. The extracted result uid is added to the observation cache to be processed later.
When an ELR is imported there are 2 records created in NBS, then processed in RTR. Those are the corresponding Order and Result records in the ODSE Observation table. Changes to the Lab Report via UI such as the action "Mark as Reviewed", only update the Order record on the Observation table. As a result, Debezium captures no changes in the Result record and the RTR pipeline never sees it - except for the very first time the ELR is imported.
I also add 2 README files. One for observation service and one for post processing service so that developers can run and debug them on their host machine to increase productivity.
JIRA
Checklist
Types of changes
What types of changes does this PR introduces?
Testing
gradle buildpass in your local?gradle buildlogs attached?Build logs