CNDE-3045 : updated format for vaccination#582
Open
jayasudhasundaram wants to merge 3 commits intomainfrom
Open
CNDE-3045 : updated format for vaccination#582jayasudhasundaram wants to merge 3 commits intomainfrom
jayasudhasundaram wants to merge 3 commits intomainfrom
Conversation
liquibase-service/src/main/resources/db/003-odse/routines/027-sp_vaccination_event-001.sql
Outdated
Show resolved
Hide resolved
upasanapattnaik-eq
approved these changes
Aug 20, 2025
upasanapattnaik-eq
suggested changes
Aug 20, 2025
Contributor
upasanapattnaik-eq
left a comment
upasanapattnaik-eq
left a comment
There was a problem hiding this comment.
The postprocessing stored procedure and any other process that references this column also needs to be updated to reflect this change.
Contributor
|
Please add test coverage for new lines of code. |
|
| @@ -88,7 +88,7 @@ public class Vaccination { | |||
| private Long organizationUid; | |||
|
|
|||
| @Column(name="PHC_UID") | |||
Contributor
|
The update functionality looks good for multiple investigations. Once the delete logic is confirmed, this PR should be good to merge. |
upasanapattnaik-eq
approved these changes
Sep 15, 2025
Contributor
upasanapattnaik-eq
left a comment
upasanapattnaik-eq
left a comment
There was a problem hiding this comment.
Functionality works as expected.
Deletes will be reviewed separately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes
updated format for sp_vaccination_event
JIRA
Checklist
Types of changes
What types of changes does this PR introduces?
Testing
gradle buildpass in your local?gradle buildlogs attached?