feat : revise plot function of 'hgf_ibrb' and 'hgf_ibrb single' #177
Open
juhajulia wants to merge 4 commits intoCCS-Lab:feat/ehgffrom
Open
feat : revise plot function of 'hgf_ibrb' and 'hgf_ibrb single' #177juhajulia wants to merge 4 commits intoCCS-Lab:feat/ehgffrom
juhajulia wants to merge 4 commits intoCCS-Lab:feat/ehgffrom
Conversation
juhajulia
commented
Jan 1, 2026
juhajulia
commented
- Let fixed parameters do not appear when plotting results
- Changed variable names in plot function (kappa (phasic volatility) -> kappa (coupling between level A-B))
bugoverdose
changed the title
bugoverdose
reviewed
Feb 4, 2026
Comment on lines
+600
to
+603
| sample_all <- zeta | ||
| if (length(unique(sample_all)) >1) { | ||
| plots[[k]] <- plotDist( | ||
| sample = pars$omega[, i], | ||
| sample = zeta, |
Member
There was a problem hiding this comment.
Is the sample_all part needed?
Suggestion: removing sample_all and add whitespace in the condition.
Suggested change
| sample_all <- zeta | |
| if (length(unique(sample_all)) >1) { | |
| plots[[k]] <- plotDist( | |
| sample = pars$omega[, i], | |
| sample = zeta, | |
| if (length(unique(zeta)) > 1) { | |
| plots[[k]] <- plotDist( | |
| sample = zeta, |
R/inst/plotting/plot_functions.R
Outdated
Comment on lines
+588
to
+589
| if (length(unique(sample_all)) >1) { | ||
| plots[[k]] <- plotDist( |
Member
There was a problem hiding this comment.
Adding whitespace
Suggested change
| if (length(unique(sample_all)) >1) { | |
| plots[[k]] <- plotDist( | |
| if (length(unique(sample_all)) > 1) { | |
| plots[[k]] <- plotDist( |
R/inst/plotting/plot_functions.R
Outdated
Comment on lines
+574
to
+575
| if (length(unique(sample_all)) >1) { | ||
| plots[[k]] <- plotDist( |
Member
There was a problem hiding this comment.
Adding whitespace
Suggested change
| if (length(unique(sample_all)) >1) { | |
| plots[[k]] <- plotDist( | |
| if (length(unique(sample_all)) > 1) { | |
| plots[[k]] <- plotDist( |
Comment on lines
+550
to
+553
| sample_all = mu_zeta | ||
| if (length(unique(mu_zeta))>1) { | ||
| plots[[k]] <- plotDist( | ||
| sample = mu_omega[, i], | ||
| sample = mu_zeta, |
Member
There was a problem hiding this comment.
Suggestion: sample_all doesn't seem to be used + adding whitespace
Suggested change
| sample_all = mu_zeta | |
| if (length(unique(mu_zeta))>1) { | |
| plots[[k]] <- plotDist( | |
| sample = mu_omega[, i], | |
| sample = mu_zeta, | |
| if (length(unique(mu_zeta)) > 1) { | |
| plots[[k]] <- plotDist( | |
| sample = mu_zeta, |
Co-authored-by: Jinwoo Jeong <jwjeong96@gmail.com>
Co-authored-by: Jinwoo Jeong <jwjeong96@gmail.com>
Co-authored-by: Jinwoo Jeong <jwjeong96@gmail.com>
Member
|
Let's merge this to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.