Skip to content

Conversation

@AurySystem
Copy link

Noticed a lot of Lea's expressions where missing and some where cutoff, it's not perfect but it stops everything from getting cutoff now in addition to adding in all of Lea's expressions.

Other tweaks:

  • Fixed the subX offset on lea's tired part, for some reason it's shoved way further than it should be leading to hair not lining up on EXHAUSTED.
  • Fixed the designer have 299 on a part that's supposed to have 200, discovered via adaptive canvas including them

(revert readme.md before pulling)

@dmitmel
Copy link
Member

dmitmel commented Jun 8, 2021

  • Fixed the subX offset on lea's tired part, for some reason it's shoved way further than it should be leading to hair not lining up on EXHAUSTED.
  • Fixed the designer have 299 on a part that's supposed to have 200, discovered via adaptive canvas including them

If some expression isn't rendered correctly, it is a problem with the renderer, not the asset files. After all, the game does it just fine without modification.

@AurySystem
Copy link
Author

  • Fixed the subX offset on lea's tired part, for some reason it's shoved way further than it should be leading to hair not lining up on EXHAUSTED.
  • Fixed the designer have 299 on a part that's supposed to have 200, discovered via adaptive canvas including them

If some expression isn't rendered correctly, it is a problem with the renderer, not the asset files. After all, the game does it just fine without modification.

mhm, Lea.json's tried is odd it was working in the main branch but not on this one and that was before any renderer changes. We're just going to assume JavaScript is cursed and move on on that one.
As for designer.json it looks like the position it's rendered in game hides that broken reads past where it's supposed to.
The few of us aren't exactly sure how the game makes sure to render things that go off the edge correctly.
Judging from the asset files, the devs push things they want to actually render over to the left and used the screen edge on the right and on the bottom to cut things off

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants