Open
Conversation
Hagar-Usama
requested review from
NourEldinShobier,
amohamed97,
amrable,
amroakmal and
shakram02
shakram02
requested changes
Oct 13, 2020
Collaborator
shakram02
left a comment
shakram02
left a comment
There was a problem hiding this comment.
Thanks, great job.
please don't forget to remove commented code.
I'm requesting changes mainly for the filename comment.
Open
amroakmal
approved these changes
Oct 30, 2020
shakram02
approved these changes
Oct 31, 2020
| { | ||
| "editor.defaultFormatter": "esbenp.prettier-vscode", | ||
| "editor.formatOnSave": true | ||
| } No newline at end of file |
Collaborator
There was a problem hiding this comment.
is this file meant to be included in the commit?
| function downloadFile() { | ||
| GradingService | ||
| .downloadResults(props.course, props.lab).then(res => { | ||
| fileDownload(res, "results" + new Date().valueOf() + ".zip"); |
Collaborator
There was a problem hiding this comment.
this name should have an _ separator (between results and the timestamp). but that's not a major thing
Comment on lines
+93
to
+95
| clientId="653543257974-p3uuv08hcftdhkolqpl2hpbbta2d1ck2.apps.googleusercontent.com" | ||
| scope="https://www.googleapis.com/auth/spreadsheets.readonly https://www.googleapis.com/auth/drive.readonly" | ||
| render={renderProps => ( |
Collaborator
There was a problem hiding this comment.
is this a specific key for the application? is it okay if anyone can use this id?
if it's okay then leave it as is, otherwise it should be moved to an environment variable
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #44