Submission editing endpoints use submission key#85
Open
amohamed97 wants to merge 1 commit intostagingfrom
Open
Submission editing endpoints use submission key#85amohamed97 wants to merge 1 commit intostagingfrom
amohamed97 wants to merge 1 commit intostagingfrom
Conversation
NourEldinShobier
approved these changes
Oct 27, 2020
shakram02
requested changes
Oct 28, 2020
| def get_submission_files(course, lab, submission_id, submission_key): | ||
| lab_path = get_lab_path(course, lab) | ||
| return list(lab_path.glob(f"submissions/{submission_id}/*.c")) | ||
| return list(lab_path.glob(f"submissions/{submission_key}/{submission_id}/*.c")) |
Collaborator
There was a problem hiding this comment.
same note for manually joining paths. Maybe you'd like to have a PathManager to group all the joins in one place
Contributor
Author
There was a problem hiding this comment.
What I understood with PathManager is a single module that has all the needed paths but with descriptive names, did I get it right?
Collaborator
There was a problem hiding this comment.
yes, or composes the paths so it'll have something like def list_submission_files(submission_key, submission_id)
I mean, it doesn't need to have just constant fields
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #78