Adding submissions in seperate directories#81
Conversation
amohamed97
changed the title
amohamed97
force-pushed
the
BE_75_adding_submissions_in_seperate_directories
branch
from
de6320f to
991b7fc
Compare
amohamed97
force-pushed
the
BE_75_adding_submissions_in_seperate_directories
branch
from
991b7fc to
13e9375
Compare
| @@ -286,8 +288,9 @@ def import_submissions(self): | |||
|
|
|||
| iterCol = iter(submission_list) | |||
There was a problem hiding this comment.
python uses snake_case naming.
URL[0] isn't really helpful 😅 (below this line)
There was a problem hiding this comment.
about URL[0], you mean the naming ( shouldn't be capital letters ) or about the ambiguity of what I'm trying to get from URL
There was a problem hiding this comment.
You can use uppercase letters if those are constants, and yes the name is ambiguous
| """ | ||
| course_grader = select_course_grader(course_name) | ||
| course_grader.add_submissions(course_name, lab, submissions_file) | ||
| submission_key = course_grader.add_submissions(course_name, lab, submissions_file) |
There was a problem hiding this comment.
does the add_submissions(course_name, lab, submissions_file) add a single submission file? (so the function should be names add_submission without an s) or the submissions_file variable contains multiple submissions? (so it should be names submission_files)
There was a problem hiding this comment.
it adds multiple submissions, but 'submissions_file' is a compressed file containing multiple submissions, is it still more descriptive to make it submission_files?
There was a problem hiding this comment.
I think submissions_compressed_file can be more descriptive
There was a problem hiding this comment.
yes, or decompress first then pass the uncompressed files to the course_grader since it's not its responsibility to decompress files.
4 participants
Closes #75