Skip to content

Conversation

@bdpedigo
Copy link
Contributor

@bdpedigo bdpedigo commented Jan 3, 2024

No description provided.

fcollman
fcollman previously approved these changes Jan 3, 2024
@fcollman fcollman dismissed their stale review January 3, 2024 18:43

too early

@bdpedigo
Copy link
Contributor Author

bdpedigo commented Jan 3, 2024

@fcollman looks like tests are failing generally (i.e. before this PR) is that a known thing I shouldn't worry about?

@bdpedigo
Copy link
Contributor Author

bdpedigo commented Dec 9, 2024

@fcollman @ceesem would like to bring this back up - i'd like to not have to pin networkx to be <3. Looking back at my changes here, I think it could make sense to just have a function/method for

if nx.__version__ < 3:
   G = nx.from_scipy_sparse_matrix(nrn.mesh.csgraph)
else:
  G = nx.from_scipy_sparse_array(nrn.mesh.csgraph)

(I think all other diffs were from my autoformatter here)

@bdpedigo
Copy link
Contributor Author

bdpedigo commented Dec 9, 2024

I also don't know whether/how to trust tests here since they seem like they've been failing since I submitted this, lmk any thoughts on that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants