Small fix to make DuelTileEntity inheritable#18
Open
3ktoplasm wants to merge 1 commit intoCAS-ual-TY:mainfrom
Open
Small fix to make DuelTileEntity inheritable#183ktoplasm wants to merge 1 commit intoCAS-ual-TY:mainfrom
3ktoplasm wants to merge 1 commit intoCAS-ual-TY:mainfrom
Conversation
Owner
|
Are there any other changes you need? Please contact me on discord if you can |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This modification just makes a type more general and shouldn't alter the mod in any way. This is however useful to make it possible to create subclasses of DuelTileEntity, because we can then pass a variable of type BlockEntityType when calling DuelTileEntity's constructor in the subclass's constructor. I'm currently working on a mod relying on YDM and I need to inherit DuelTileEntity at some point so this solved my problem.