Skip to content

forwardAuth Support#252

Open
shinybrar wants to merge 4 commits intoCARTAvis:devfrom
shinybrar:dev
Open

forwardAuth Support#252
shinybrar wants to merge 4 commits intoCARTAvis:devfrom
shinybrar:dev

Conversation

@shinybrar
Copy link

  • Added forwardAuth support
  • Added docker-compose, Dockerfile and a sample config.json

@daikema
Copy link
Contributor

daikema commented Sep 10, 2025

Hi @shinybrar. It's great to hear that you've made progress at getting the forwardAuth solution working on your end.
I took a look at this and your corresponding schema PR, and had the following thoughts.

  • First off, if configuring forwardAuth via the config file, I don't think that we want to allow for a default header name from which to obtain a username to reduce security risks if people enable forwardAuth without an understanding of what it does such that a request could be sent using the default header.

  • We do want to ensure that CARTA operates well on CANFAR but I don't think we want CANFAR-specific text in there as is currently there in the config file that you'd included in the PR.  We've also tried to group that sort of thing into the documentation rather than directly in the code (with an existing example you can see here).

  • At the moment I don't think we're interested in adding containerization code (the Dockerfile + compose) within the controller repo itself.

  • Any changes of this sort introduced now are likely to be superceded by the time of the next release as we're working on a larger overhaul (which should also, e.g., prune out the need for the pam dependency you have installed in your runtime container if not using that auth method)

Copy link

@kswang1029 kswang1029 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we also update the controller document?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants