Skip to content

Conversation

@Whyborn
Copy link
Contributor

@Whyborn Whyborn commented Nov 7, 2025

CABLE

Description

Adds GCC specific precision specifiers for the library.

Fixes #(650)

Type of change

Please delete options that are not relevant.

  • Bug fix

📚 Documentation preview 📚: https://cable--651.org.readthedocs.build/en/651/

Copy link
Collaborator

@SeanBryan51 SeanBryan51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good once indentation is fixed

CMakeLists.txt Outdated
Comment on lines 134 to 138
if(CMAKE_Fortran_COMPILER_ID MATCHES "Intel")
add_compile_options(-r8 -i8)
elseif(CMAKE_Fortran_COMPILER_ID MATCHES "GNU")
add_compile_options(-fdefault-real-8 -fdefault-integer-8)
else()
Copy link
Collaborator

@SeanBryan51 SeanBryan51 Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a tab in here somewhere?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This indentation also looks botched?

@Whyborn
Copy link
Contributor Author

Whyborn commented Nov 7, 2025

Indentation looks correct now

@Whyborn Whyborn merged commit d07ca75 into main Nov 7, 2025
4 of 5 checks passed
@Whyborn Whyborn deleted the 650-add-gcc-specific-precision-flags branch November 7, 2025 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants