adjust plumbing to USE cable_surface_types offline #446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@har917 you're tagged in the issue but perhaps here is more appropriate |
Indent issue.
bschroeter
reviewed
Nov 6, 2024
JhanSrbinovsky
added
the
priority:high
…ne-we-can-get-round-the-need-for-this-by-modifying-the-files-names-in-the-offlinecoupled-codebases-to-be-the-same
Collaborator
Author
|
@bschroeter can you have a look at this. The next tranche of AM3 updates will be much simpler if this does in first |
Collaborator
Author
Actually to get ESM1,6 to work as well - so Labels etc will be updated |
4 tasks
ccarouge
approved these changes
Nov 24, 2024
Member
ccarouge
left a comment
ccarouge
left a comment
There was a problem hiding this comment.
It's fine for me. I've made a commit (so pull before pushing if needed) to align all the USE statements where it was obviously needed from the changes view.
Is there a plan to change cable_surface_types.F90 to a namelist down the track?
JhanSrbinovsky
deleted the
436-ifdef-okay-for-now-but-surely-for-this-one-we-can-get-round-the-need-for-this-by-modifying-the-files-names-in-the-offlinecoupled-codebases-to-be-the-same
branch
Collaborator
Author
absolutely |
JhanSrbinovsky
restored the
436-ifdef-okay-for-now-but-surely-for-this-one-we-can-get-round-the-need-for-this-by-modifying-the-files-names-in-the-offlinecoupled-codebases-to-be-the-same
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CABLE
The same module name can indeed be USEd as there are seperate versions picked up by coupled/offline apps. However some additional plumbing needs to be tweaked offline.
Please see issue for further details:
Fixes #436
Type of change
Checklist
Please add a reviewer when ready for review.
📚 Documentation preview 📚: https://cable--446.org.readthedocs.build/en/446/