Skip to content

Conversation

@sgmenda
Copy link
Contributor

@sgmenda sgmenda commented Dec 11, 2025

For aws/aws-lc#2891, I made some simple vectors to validate full decaps keys. I needed a new schema because the existing mlkem_test_schema.json only supports seed keys, and not full keys: https://github.com/C2SP/wycheproof/blob/main/schemas/mlkem_test_schema.json#L80-L84

Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Would love to get another +1 review on this, but generally makes sense to me and doesn't seem like a good candidate for folding into existing test files/schemas.

@cpu
Copy link
Member

cpu commented Dec 18, 2025

Would love to get another +1 review on this

@sgmenda I chatted with Filippo about this OOB and he gave a verbal +1 to the PR but also suggested naming the test files to include "semi-expanded" (e.g. something like schemas/mlkem_semi_expanded_decaps_test_schema.json and testvectors_v1/mlkem_XXXX_semi_expanded_decaps_test.json). Are you open to that change? I think we can merge this afterwards.

@cpu cpu merged commit 7c661e3 into C2SP:main Dec 19, 2025
1 check passed
@cpu
Copy link
Member

cpu commented Dec 19, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants