Skip to content

Conversation

@corink21
Copy link
Contributor

Processing chain workflow for simulations with full chemistry and aerosol dynamics.
Initialization of ART fields and boundary conditions from CAM-Chem data (https://www.acom.ucar.edu/cam-chem/cam-chem.shtml).

@corink21 corink21 self-assigned this Oct 16, 2025
@corink21 corink21 requested a review from mjaehn October 16, 2025 09:08
Copy link
Contributor

@mjaehn mjaehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @corink21, thanks a lot for this development! I can't test this myself, so I'm relying on everything working.

Since you have added...

  • a new case,
  • a new job,
  • and two new tools scripts,
    ... could you adapt the corresponding parts in the documentation? This would be much appreciated. 🙂

Otherwise, everything LGTM

@github-actions
Copy link

github-actions bot commented Nov 11, 2025

PR Preview Action v1.6.2
Preview removed because the pull request was closed.
2025-11-18 10:01 UTC

@corink21
Copy link
Contributor Author

Hi @corink21, thanks a lot for this development! I can't test this myself, so I'm relying on everything working.

Since you have added...

  • a new case,
  • a new job,
  • and two new tools scripts,
    ... could you adapt the corresponding parts in the documentation? This would be much appreciated. 🙂

Otherwise, everything LGTM

I have added docstrings to the tools scripts and added the corresponding entries in the docs/functions.rst file. Before I continue documenting the remaining scripts and files, could you let me know if the updates to the documentation so far look correct and complete?

@mjaehn
Copy link
Contributor

mjaehn commented Nov 13, 2025

Hi @corink21, thanks a lot - looks good to me. I just added another requirement for the docs environment (which is necessary if Python 3.12 is used). At some stages, the code tries to import distutils, which is part of the setuptools package.

The docs preview should now link and show the content of your added functions (camchem_ic_lbc_reggrid).

@corink21
Copy link
Contributor Author

Hi @corink21, thanks a lot - looks good to me. I just added another requirement for the docs environment (which is necessary if Python 3.12 is used). At some stages, the code tries to import distutils, which is part of the setuptools package.

The docs preview should now link and show the content of your added functions (camchem_ic_lbc_reggrid).

I have added the remaining docs.

Copy link
Contributor

@mjaehn mjaehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@corink21 corink21 merged commit 0715a47 into main Nov 18, 2025
1 check passed
@corink21 corink21 deleted the empa-full-chem branch November 18, 2025 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants