-
Notifications
You must be signed in to change notification settings - Fork 5
Full chemistry case #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
mjaehn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @corink21, thanks a lot for this development! I can't test this myself, so I'm relying on everything working.
Since you have added...
- a new case,
- a new job,
- and two new tools scripts,
... could you adapt the corresponding parts in the documentation? This would be much appreciated. 🙂
Otherwise, everything LGTM
|
I have added docstrings to the tools scripts and added the corresponding entries in the docs/functions.rst file. Before I continue documenting the remaining scripts and files, could you let me know if the updates to the documentation so far look correct and complete? |
|
Hi @corink21, thanks a lot - looks good to me. I just added another requirement for the docs environment (which is necessary if Python 3.12 is used). At some stages, the code tries to import The docs preview should now link and show the content of your added functions ( |
CAM-Chem interpolation tools
dictionary variables.
I have added the remaining docs. |
mjaehn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Processing chain workflow for simulations with full chemistry and aerosol dynamics.
Initialization of ART fields and boundary conditions from CAM-Chem data (https://www.acom.ucar.edu/cam-chem/cam-chem.shtml).