Muphys bug fix: drivers run_graupel_only and run_full_muphys #877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…merge' into muphys_bug_fix
vectorflux
force-pushed
the
muphys_bug_fix
branch
from
35d058f to
3752592
Compare
havogt
reviewed
Sep 24, 2025
...s/muphys/src/icon4py/model/atmosphere/subgrid_scale_physics/muphys/driver/run_full_muphys.py
Outdated
Show resolved
Hide resolved
Clean up the graupel_only driver, and create an integration test to run through pytest. Co-authored-by: Will Sawyer <wsawyer@cscs.ch>
Co-authored-by: Will Sawyer <vectorflux@gmail.com> Co-authored-by: Will Sawyer <wsawyer@cscs.ch>
havogt
reviewed
Dec 5, 2025
| return testing_defs.get_test_data_root_path() / "full_muphys_data" / experiment.name | ||
|
|
||
|
|
||
| @dataclasses.dataclass(frozen=True) |
Contributor
There was a problem hiding this comment.
refactor utility functions to be shared between full_muphys and graupel_only tests
havogt
reviewed
Dec 5, 2025
| @classmethod | ||
| def allocate(cls, allocator: gtx_typing.FieldBufferAllocationUtil, domain: gtx.Domain): | ||
| zeros = functools.partial(gtx.zeros, domain=domain, allocator=allocator) | ||
| # TODO +1 size fields? |
Contributor
There was a problem hiding this comment.
make these fields horizontal only
|
Mandatory Tests Please make sure you run these tests via comment before you merge!
Optional Tests To run benchmarks you can use:
To run tests and benchmarks with the DaCe backend you can use:
To run test levels ignored by the default test suite (mostly simple datatest for static fields computations) you can use:
For more detailed information please look at CI in the EXCLAIM universe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses minor deficiencies in the graupel and saturation_adjustment GT4Py programs, which might influence performance, but more importantly in the run_graupel_only.py and run_full_muphys.py drivers which call them. These were restructured to improve performance, in particular by performing a set-up of both programs in the initialization step.