remove the workaround separating vertical and horizontal connectivities #859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
OBS this does not work on this branch: for the halo_construction, I had to do it in order to get the geometry tests run. |
|
Mandatory Tests Please make sure you run these tests via comment before you merge!
Optional Tests To run benchmarks you can use:
To run tests and benchmarks with the DaCe backend you can use:
To run test levels ignored by the default test suite (mostly simple datatest for static fields computations) you can use:
For more detailed information please look at CI in the EXCLAIM universe. |
havogt
reviewed
Sep 4, 2025
Comment on lines
+453
to
+456
| def _grid_connectivities( | ||
| self, grid: icon_grid.IconGrid | ||
| ) -> dict[str, gtx.Connectivity | gtx.Dimension]: | ||
| return grid.connectivities |
Contributor
There was a problem hiding this comment.
I guess this function should disappear in the end?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the workaround in the factory separating the vertical and horizontal connectivities, (originally needed for 1D (vertical or horizontal) fields)